Skip to content

Add notification in navbar. #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

xuezhaojun
Copy link
Member

@xuezhaojun xuezhaojun commented Jun 19, 2025

Related: #488

image

@openshift-ci openshift-ci bot requested review from mikeshng and qiujian16 June 19, 2025 06:05
Copy link
Contributor

openshift-ci bot commented Jun 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Jun 19, 2025

Deploy Preview for open-cluster-management ready!

Name Link
🔨 Latest commit 9809e3f
🔍 Latest deploy log https://app.netlify.com/projects/open-cluster-management/deploys/685a2284d05a530008a5a63f
😎 Deploy Preview https://deploy-preview-491--open-cluster-management.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@@ -64,11 +64,15 @@ outputs:

menu:
main:
- identifier: v1.0.0-released
weight: 1
name: "🎉 v1.0.0 Released!"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikeshng The content and the url could be customized once we decided.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS like background color also could be cutomized.

@xuezhaojun xuezhaojun changed the title Add notification in navbar. WIP: Add notification in navbar. Jun 19, 2025
@xuezhaojun xuezhaojun force-pushed the add-v1.0.0-release-notification-in-navbar branch 2 times, most recently from 1c56482 to ab9c35f Compare June 19, 2025 08:32
Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing!

@mikeshng
Copy link
Member

@xuezhaojun I think this PR is ready to be merged once we point it to #492 Thanks!

@xuezhaojun
Copy link
Member Author

xuezhaojun commented Jun 24, 2025

@xuezhaojun I think this PR is ready to be merged once we point it to #492 Thanks!

Hi, @mikeshng Talked with @qiujian16, we're waiting for several documents to be merged.

The merge sequence will be: [merge docuements for new features] -> merge v1.0 version selecting and create a new branch v1.0 -> [merge this PR to add a highlight reminder]

I have changed the point to url to the release page, once the v1.0 branch is created, we are ready to unhold the PR.

@xuezhaojun xuezhaojun force-pushed the add-v1.0.0-release-notification-in-navbar branch 2 times, most recently from 9b624d1 to caf4658 Compare June 24, 2025 03:52
@xuezhaojun xuezhaojun force-pushed the add-v1.0.0-release-notification-in-navbar branch from caf4658 to 9809e3f Compare June 24, 2025 03:58
@xuezhaojun xuezhaojun changed the title WIP: Add notification in navbar. Add notification in navbar. Jun 26, 2025
@xuezhaojun xuezhaojun merged commit b983f24 into open-cluster-management-io:main Jun 26, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants