-
Notifications
You must be signed in to change notification settings - Fork 74
Add notification in navbar. #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notification in navbar. #491
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for open-cluster-management ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@@ -64,11 +64,15 @@ outputs: | |||
|
|||
menu: | |||
main: | |||
- identifier: v1.0.0-released | |||
weight: 1 | |||
name: "🎉 v1.0.0 Released!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikeshng The content and the url could be customized once we decided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSS like background color also could be cutomized.
1c56482
to
ab9c35f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing!
@xuezhaojun I think this PR is ready to be merged once we point it to #492 Thanks! |
Hi, @mikeshng Talked with @qiujian16, we're waiting for several documents to be merged. The merge sequence will be: [merge docuements for new features] -> merge v1.0 version selecting and create a new branch v1.0 -> [merge this PR to add a highlight reminder] I have changed the |
9b624d1
to
caf4658
Compare
Signed-off-by: xuezhaojun <[email protected]>
caf4658
to
9809e3f
Compare
b983f24
into
open-cluster-management-io:main
Related: #488